Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLC-432]: Fix hanging problem when source and target clusters is not running #428

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

kutluhanmetin
Copy link
Contributor

  • The reason of the problem is that we forgot to handle context errors in for loop while waiting migration to be in progress, so even if we have a timeout error it waits for it to be in progress forever.
  • Also this PR increases the timeout of the context, because it was 30 seconds which is same with the backend. So sometimes it used to fail with timeout, sometimes with Unable to connect to any cluster error. After increasing the timeout, user will consistently see the Unable to connect to any cluster error.

@kutluhanmetin kutluhanmetin requested review from yuce and srknzl November 7, 2023 18:56
Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct, needs testing. left to qa

@kutluhanmetin kutluhanmetin merged commit 16da1df into hazelcast:dmt Nov 14, 2023
5 checks passed
@degerhz degerhz added this to the Data Migration Tool [Phase 1] milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants