Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLC-431]: dmt command hangs when unable to connect w/ the migration cluster #429

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[CLC-431]: dmt command hangs when unable to connect w/ the migration cluster #429

merged 1 commit into from
Nov 14, 2023

Conversation

kutluhanmetin
Copy link
Contributor

No description provided.

@kutluhanmetin kutluhanmetin requested review from yuce and srknzl November 7, 2023 19:03
srknzl
srknzl reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@srknzl srknzl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont the client hang in the connect stage now? Don't we need to add some timeout ?

EDIT: I guess we won't do that due to the timeout flag in clc, but do we document that in the help (-h) page? Also we should have the timeout by default IMO.

@srknzl
Copy link
Member

srknzl commented Nov 9, 2023

Also do we print what @yuce suggested here: https://hazelcast.atlassian.net/browse/CLC-431?focusedCommentId=88217 ?

@kutluhanmetin
Copy link
Contributor Author

@srknzl yes, we are printing what @yuce suggested, it will hang with “Connecting …”.

@kutluhanmetin kutluhanmetin requested a review from srknzl November 10, 2023 07:18
@kutluhanmetin kutluhanmetin merged commit 404e09a into hazelcast:dmt Nov 14, 2023
5 checks passed
@sumnerib sumnerib linked an issue Nov 14, 2023 that may be closed by this pull request
DMT: dmt command hangs when unable to connect w/ the migration cluster [CLC-431] #426
Closed
@degerhz degerhz added this to the Data Migration Tool [Phase 1] milestone Nov 18, 2023
@yuce yuce mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srknzl srknzl srknzl approved these changes

@yuce yuce yuce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Data Migration Tool [Phase 1]
Development

Successfully merging this pull request may close these issues.

DMT: dmt command hangs when unable to connect w/ the migration cluster [CLC-431]
4 participants
@kutluhanmetin @srknzl @yuce @degerhz