Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single definition of the supported JDK versions #715

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Use a single definition of the supported JDK versions #715

merged 2 commits into from
Jan 23, 2024

Conversation

ldziedziul
Copy link
Contributor

Define supported JDKs in a single place: ./.github/workflows/get-supported-jdks.yaml

@ldziedziul ldziedziul self-assigned this Jan 22, 2024
@ldziedziul ldziedziul marked this pull request as ready for review January 22, 2024 18:45
@ldziedziul ldziedziul requested a review from a team as a code owner January 22, 2024 18:45
@ldziedziul ldziedziul changed the title Dynamic jdk matrix Use a single definition of the supported JDK versions Jan 22, 2024
JackPGreen
JackPGreen approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@JackPGreen JackPGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, a lot.

@ldziedziul ldziedziul merged commit 8e75895 into master Jan 23, 2024
5 of 9 checks passed
@ldziedziul ldziedziul deleted the dynamic-jdk-matrix branch January 23, 2024 11:04
@JackPGreen JackPGreen mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orcunc orcunc orcunc approved these changes

@JackPGreen JackPGreen JackPGreen approved these changes

@frant-hartm frant-hartm Awaiting requested review from frant-hartm

Assignees

@ldziedziul ldziedziul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldziedziul @JackPGreen @orcunc