Convert manual post-release test into a reusable GitHub Action [DI-316] [5.3.z] #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6] (#814) Converts the existing manual [post-release Docker checklist](https://hazelcast.atlassian.net/wiki/spaces/EN/pages/4681302104/Create+release+5.x#Docker-release-tag-test) into a single GitHub Action. Improvements: - faster - runs in parallel - reproducible - requires no special credentials - better coverage - leveraging existing smoke test (i.e. beyond just "does it start") - explicit expectations - requiring expected JDK version upfront avoids "looks ok" confirmation bias when checking outputs Fixes: [DI-316](https://hazelcast.atlassian.net/browse/DI-316) Note - it’s difficult to test a new, manual GitHub action that depends on repo secrets. I’ve tested by committing with hardcoded values and then reverting for PR - once merged, if there any issues will be much easier to fix as can be run direct from branch. [DI-316]: https://hazelcast.atlassian.net/browse/DI-316?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Łukasz Dziedziul <[email protected]>
The action added in #814 could not be properly tested via GitHub until merged and at that point additional defects were discovered. [Example of now successful completion](https://github.com/hazelcast/hazelcast-docker/actions/runs/11943342729). Fixes: [DI-316](https://hazelcast.atlassian.net/browse/DI-316) [DI-316]: https://hazelcast.atlassian.net/browse/DI-316?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
This doesn't need backporting 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #814 & #827