Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL V6 container support [DI-375] #844

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add RHEL V6 container support [DI-375] #844

wants to merge 1 commit into from

Conversation

JackPGreen
Copy link
Collaborator

@JackPGreen JackPGreen commented Dec 10, 2024

Re-instates the version selection logic removed in #811 to support V6 RHEL.

Fixes: DI-375

Re-instates the version selection logic removed in #811 to support `V6` RHEL.

Fixes: [DI-319](https://hazelcast.atlassian.net/browse/DI-319)
@JackPGreen JackPGreen self-assigned this Dec 10, 2024
@JackPGreen JackPGreen changed the title Add RHEL V6 container support [DI-319] Add RHEL V6 container support [DI-375] Dec 10, 2024
JackPGreen added a commit to hazelcast/management-center-docker that referenced this pull request Dec 11, 2024
@@ -101,6 +104,12 @@ jobs:
OCP_LOGIN_PASSWORD,CN/OCP_PASSWORD
OCP_CLUSTER_URL,CN/OCP_CLUSTER_URL

- name: Set scan registry secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious. how did this work before without this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were hardcoded env variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants