Bigger integers #1548
Open
Bigger integers #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1548 +/- ##
==========================================
- Coverage 50.33% 50.31% -0.02%
==========================================
Files 103 103
Lines 10442 10444 +2
==========================================
- Hits 5256 5255 -1
- Misses 5186 5189 +3
|
7h3kk1d
reviewed
Mar 4, 2025
| }; | ||
|
|
||
| let float_of_int = d => { | ||
| let-unbox n = (Int, d); | ||
| Some(fresh(Float(float_of_int(n)))); | ||
| Some(fresh(Float(Bigint.to_float(n)))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some more integers at the end of the number line, thought we might want them in Hazel.
This pr replaces the integers in Hazel with big integers, similar to python 3.0's approach to integers. Means we can't get integer overflows, and importantly for my work means integers are a little more mathematically well-behaved.
I tried running my AoC code on this branch and it didn't cause any slowdown.