Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused changed argument from BlueZManager._run_advertisement_callbacks #1633

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Aug 21, 2024

  • If the pull request adds functionality, the docs should be updated.
  • Modify the CHANGELOG.rst, describing your changes as is specified by the
    guidelines in that document.
  • The pull request should work for Python 3.8+ on the following platforms:
    • Windows 10, version 16299 (Fall Creators Update) and greater
    • Linux distributions with BlueZ >= 5.43
    • OS X / macOS >= 10.11
  • Squash all your commits on your PR branch, if the commits are not solving
    different problems and you are committing them in the same PR. In that case,
    consider making several PRs instead.
  • Feel free to add your name as a contributor to the AUTHORS.rst file!

@bdraco
Copy link
Contributor Author

bdraco commented Aug 21, 2024

Not sure if this warrants a CHANGELOG entry since its an internal code cleanup and there is no user facing change or effect

@bdraco bdraco marked this pull request as ready for review August 21, 2024 23:53
@dlech
Copy link
Collaborator

dlech commented Aug 22, 2024

looks good, thanks

@dlech dlech merged commit a065527 into hbldh:develop Aug 22, 2024
13 checks passed
@bdraco bdraco deleted the remove_unused branch August 22, 2024 00:45
@bdraco
Copy link
Contributor Author

bdraco commented Aug 22, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants