Merge pull request #74 from hborras/temp-v6

Check Headers before use in error responses
hborras · Mar 6, 2020 · 3dcb54d · 3dcb54d
2 parents 5575342 + 9ecb070
commit 3dcb54d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/TwitterAds/Errors/RateLimit.php b/src/TwitterAds/Errors/RateLimit.php
@@ -31,8 +31,8 @@ class RateLimit extends TwitterAdsException
     public function __construct($message, $code, Exception $previous = null, $errors, $headers)
     {
         parent::__construct($message, $code, null, $errors);
-        $this->retryAfter = $headers['x_rate_limit_limit'];
-        $this->resetAt = $headers['x_rate_limit_reset'];
+        $this->retryAfter = $headers['x_rate_limit_limit'] ? $headers['x_rate_limit_limit'] : '';
+        $this->resetAt = $headers['x_rate_limit_reset'] ? $headers['x_rate_limit_reset'] : '';
     }
 
     /**

diff --git a/src/TwitterAds/Errors/ServiceUnavailable.php b/src/TwitterAds/Errors/ServiceUnavailable.php
@@ -27,7 +27,7 @@ class ServiceUnavailable extends TwitterAdsException
     public function __construct($message, $code, Exception $previous = null, $errors, $headers)
     {
         parent::__construct($message, $code, null, $errors);
-        $this->retryAfter = $headers['retry-after'];
+        $this->retryAfter = isset($headers['retry-after']) ? $headers['retry-after'] : '';
     }
 
     /**