Fix alternativeGraphicRepresentation for isPartOf

Reported in logs
hbz · Sep 26, 2023 · 7672f5a · 7672f5a
1 parent 0c114ea
commit 7672f5a
Show file tree

Hide file tree

Showing 2 changed files with 145 additions and 2 deletions.
diff --git a/src/main/resources/alma/fix/macros.fix b/src/main/resources/alma/fix/macros.fix
@@ -42,8 +42,9 @@ do put_macro("alternateGraphicRepresationIsPartOf")
           end
         else    
           copy_field("[email protected]","alternateGraphicRepresentation[].$append.script.id")
-          copy_field("[email protected]","alternateGraphicRepresentation[].$last.script.label")        
-          set_array("alternateGraphicRepresentation[].$last.record.isPartOf[].$last.hasSuperordinate[].$append")
+          copy_field("[email protected]","alternateGraphicRepresentation[].$last.script.label")
+          set_array("alternateGraphicRepresentation[].$last.record.isPartOf[]")        
+          set_array("alternateGraphicRepresentation[].$last.record.isPartOf[].$append.hasSuperordinate[]")
           copy_field("$880.a","alternateGraphicRepresentation[].$last.record.isPartOf[].$last.hasSuperordinate[].$append.label")
           copy_field("$880.v", "alternateGraphicRepresentation[].$last.record.isPartOf[].$last.numbering")
         end

diff --git a/src/test/resources/alma-fix/99372680948006441.json b/src/test/resources/alma-fix/99372680948006441.json
@@ -0,0 +1,142 @@
+{
+  "@context" : "http://lobid.org/resources/context.jsonld",
+  "alternateGraphicRepresentation" : [ {
+    "script" : {
+      "id" : "https://unicode.org/iso15924/iso15924.txt#(B",
+      "label" : "Lateinisch"
+    },
+    "record" : {
+      "isPartOf" : [ {
+        "hasSuperordinate" : [ {
+          "label" : "Hot　Spots　in　Global　Politics"
+        } ]
+      } ]
+    }
+  } ],
+  "almaMmsId" : "99372680948006441",
+  "isbn" : [ "0745656722", "9780745656724", "0745674275", "9780745674278" ],
+  "oclcNumber" : [ "843639961" ],
+  "title" : "Congo",
+  "edition" : [ "1st ed" ],
+  "publication" : [ {
+    "startDate" : "2013",
+    "type" : [ "PublicationEvent" ],
+    "location" : [ "Cambridge :" ],
+    "publishedBy" : [ "Polity" ]
+  } ],
+  "describedBy" : {
+    "id" : "http://lobid.org/resources/99372680948006441",
+    "label" : "Webseite der hbz-Ressource 99372680948006441",
+    "type" : [ "BibliographicDescription" ],
+    "inDataset" : {
+      "id" : "http://lobid.org/resources/dataset#!",
+      "label" : "lobid-resources – Der hbz-Verbundkatalog als Linked Open Data"
+    },
+    "resultOf" : {
+      "type" : [ "CreateAction" ],
+      "endTime" : "0000-00-00T00:00:00",
+      "instrument" : {
+        "id" : "https://github.com/hbz/lobid-resources",
+        "type" : [ "SoftwareApplication" ],
+        "label" : "Software lobid-resources"
+      },
+      "object" : {
+        "id" : "https://lobid.org/marcxml/99372680948006441",
+        "dateCreated" : "2023-07-07",
+        "dateModified" : "2023-08-30",
+        "type" : [ "DataFeedItem" ],
+        "label" : "hbz-Ressource 99372680948006441 im Exportformat MARC21 XML",
+        "inDataset" : {
+          "id" : "https://datahub.io/dataset/hbz_unioncatalog",
+          "label" : "hbz_unioncatalog"
+        },
+        "sourceOrganization" : {
+          "id" : "http://lobid.org/organisations/DE-MiAaPQ#!",
+          "label" : "lobid Organisation"
+        },
+        "provider" : {
+          "id" : "http://lobid.org/organisations/DE-MiAaPQ#!",
+          "label" : "lobid Organisation"
+        },
+        "modifiedBy" : [ {
+          "id" : "http://lobid.org/organisations/DE-MiAaPQ#!",
+          "label" : "lobid Organisation"
+        } ]
+      }
+    },
+    "license" : [ {
+      "id" : "http://creativecommons.org/publicdomain/zero/1.0",
+      "label" : "Creative Commons-Lizenz CC0 1.0 Universal"
+    } ]
+  },
+  "sameAs" : [ {
+    "id" : "http://worldcat.org/oclc/843639961",
+    "label" : "OCLC Ressource"
+  } ],
+  "isPartOf" : [ {
+    "type" : [ "IsPartOfRelation" ],
+    "hasSuperordinate" : [ {
+      "label" : "Hot Spots in Global Politics"
+    } ]
+  }, {
+    "type" : [ "IsPartOfRelation" ],
+    "hasSuperordinate" : [ {
+      "label" : "Global Political Hot Spots"
+    } ]
+  } ],
+  "related" : [ {
+    "isbn" : [ "9780745648439", "0745648436" ]
+  }, {
+    "isbn" : [ "9780745648446", "0745648444" ]
+  } ],
+  "language" : [ {
+    "id" : "http://id.loc.gov/vocabulary/iso639-2/eng",
+    "label" : "Englisch"
+  } ],
+  "extent" : "1 online resource (262 p.)",
+  "note" : [ "Description based upon print version of record." ],
+  "abstract" : [ "The Democratic Republic of Congo has become one of the world's bloodiest  hot spots. 2003 saw the end of a five-year war in which millions lost  their lives - one of the deadliest conflicts since World War II. Despite  recent peace agreements and democratic elections, the country is still  plagued by army and militia violence. Congo remains deeply troubled,  since the deep-rooted causes of conflict have not been adequately  addressed. The conflict in the DRC has divided opinion; some call it a civil war,  or a war of aggression by the country's neighbours; others a  continuation of Rwanda's" ],
+  "langNote" : [ "English" ],
+  "subject" : [ {
+    "type" : [ "Concept" ],
+    "source" : {
+      "label" : "Library of Congress Subject Headings",
+      "id" : "https://id.loc.gov/authorities/subjects.html"
+    },
+    "label" : "Congo (Democratic Republic) / Politics and government."
+  }, {
+    "type" : [ "Concept" ],
+    "source" : {
+      "label" : "Dewey-Dezimalklassifikation",
+      "id" : "https://d-nb.info/gnd/4149423-4"
+    },
+    "label" : "967.51034",
+    "notation" : "967.51034"
+  } ],
+  "subjectslabels" : [ "Congo (Democratic Republic) / Politics and government." ],
+  "medium" : [ {
+    "label" : "Datenträger",
+    "id" : "http://rdaregistry.info/termList/RDAMediaType/1003"
+  }, {
+    "label" : "Online-Ressource",
+    "id" : "http://rdaregistry.info/termList/RDACarrierType/1018"
+  } ],
+  "bibliographicLevel" : {
+    "label" : "Monograph/Item",
+    "id" : "https://www.loc.gov/marc/bibliographic/bdleader.html#Monograph_Item"
+  },
+  "type" : [ "BibliographicResource", "Bibliography", "Book" ],
+  "responsibilityStatement" : [ "Thomas Turner." ],
+  "contribution" : [ {
+    "agent" : {
+      "label" : "Turner, Thomas",
+      "type" : [ "Person" ]
+    },
+    "role" : {
+      "id" : "http://id.loc.gov/vocabulary/relators/cre",
+      "label" : "Schöpfer/in"
+    },
+    "type" : [ "Contribution" ]
+  } ],
+  "id" : "http://lobid.org/resources/99372680948006441#!"
+}