-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of etikett maker? #2106
Comments
EtikettMaker works as a fallback, to ensure that every ID has a label.
I don't understand what you mean. |
I am down to six labels that are still in the labels.json file. All others are migrated to the fix OR could be deleted since they were already provided for in the fix.
I have two questions: Should I explicitly mark Edoweb links as such, at the moment they come with the label lobid-resources/src/test/resources/alma-fix/99370970534006441.json Lines 79 to 82 in d2a1bce
Does Digitool still exist? e.g. digitool links provided here are broken: https://bibliothek.dguv.de/?searchhash=OCLC_4a35f16c422b7ea4d408095fb5fbfbc6aaeadf74&top=y&detail=2 Additionally: For lobid Resource and lobid Organisation I need an additional fallback. |
I am almost done with all labels. It seems that none if the labels that are explicitly added in the ettiket maker are needed. The last hold dewey-labels.json was not needed since the mapping for dewey worked differently. There still are two features that seems to be related to the ettiket maker:
Could it make sense to create a static json context instead of the dynamical way of the ettiket maker, which gets published. |
For more context see: #2123 (comment)
I am not sure if it is such a good idea to have two different sources for mapping adding labels to our elements.
In context of RPB I am reusing the lobid transformation but all elements that receive an label from the ettiket maker are not part of the transformation. Therefore I suggest using lookups instead of the ettiket maker. I dont know what this means regarding the performance but it helps with the reusability of lobid.
The text was updated successfully, but these errors were encountered: