Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of etikett maker? #2106

Open
TobiasNx opened this issue Dec 5, 2024 · 3 comments
Open

Get rid of etikett maker? #2106

TobiasNx opened this issue Dec 5, 2024 · 3 comments

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented Dec 5, 2024

I am not sure if it is such a good idea to have two different sources for mapping adding labels to our elements.
In context of RPB I am reusing the lobid transformation but all elements that receive an label from the ettiket maker are not part of the transformation. Therefore I suggest using lookups instead of the ettiket maker. I dont know what this means regarding the performance but it helps with the reusability of lobid.

@TobiasNx TobiasNx changed the title Get rid of ettiket maker? Get rid of etikett maker? Dec 5, 2024
@dr0i
Copy link
Member

dr0i commented Dec 9, 2024

EtikettMaker works as a fallback, to ensure that every ID has a label.

all elements that receive an label from the ettiket maker are not part of the transformation.

I don't understand what you mean.

@TobiasNx
Copy link
Contributor Author

I am down to six labels that are still in the labels.json file. All others are migrated to the fix OR could be deleted since they were already provided for in the fix.

[
  {
    "uri": "http://edoweb-rlp.de/resource",
    "label": "Edoweb"
  },
  {
    "uri": "http://www.edoweb-rlp.de/resource",
    "label": "Edoweb"
  },
  {
    "uri": "https://www.edoweb-rlp.de/resource",
    "label": "Edoweb"
  },
  {
    "uri": "http://lobid.org/resources",
    "label": "lobid Ressource"
  },
  {
    "uri": "http://lobid.org/organisations",
    "label": "lobid Organisation"
  },
  {
    "uri": "http://digitool.hbz-nrw.de:1801/webclient",
    "label": "Digitool"
  }
]

I have two questions:

Should I explicitly mark Edoweb links as such, at the moment they come with the label Archivierte Online-Ressouce provided by the marc data:

"fulltextOnline" : [ {
"label" : "Archivierte Online-Ressource",
"id" : "https://www.edoweb-rlp.de/resource/edoweb:7042958"
}, {

Does Digitool still exist? e.g. digitool links provided here are broken: https://bibliothek.dguv.de/?searchhash=OCLC_4a35f16c422b7ea4d408095fb5fbfbc6aaeadf74&top=y&detail=2

Additionally:

For lobid Resource and lobid Organisation I need an additional fallback.

@TobiasNx
Copy link
Contributor Author

I am almost done with all labels. It seems that none if the labels that are explicitly added in the ettiket maker are needed. The last hold dewey-labels.json was not needed since the mapping for dewey worked differently.

There still are two features that seems to be related to the ettiket maker:

  1. Adding labels to unspecific ids, that are missing labels by using the url.
    The explicit handling of labels for uris and labels for base urls is already replaced.
    Can we recreate the first feature somehow.

  2. Creating the json context.

Could it make sense to create a static json context instead of the dynamical way of the ettiket maker, which gets published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants