-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lookup tables as git submodules #1902
Conversation
Do "git config --global submodule.recurse true" once in your checked out repo. Further "git pull" will automatically update the submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do "git config --global submodule.recurse true" once in your checked out repo.
I don't think that's such a good recommendation. I'd suggest --local
instead (which is the default). Or just use git pull --recurse-submodules
explicitly.
|
|
Also we do not need a specific |
@blackwinter suggested to use gitsubmodules to easily be in sync with our repos containing lookup tables.
We have Re dewey: done that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two further questions:
Shouldn't we delete the old lookup file in the old maps folder that are now used with the submodules?
Also shouldn't we document in the maps folder, that for certain maps the submodules are used, not just in the over-all README.md
Otherwise +1
I've deleted now |
Complements ce4e73b.
okay, then go for it. |
Unfortunatley it seem not possible to have the submodules not in a detached state (may depend on the git version) but you have to do |
Do [edited:]
git config --local submodule.recurse true
once in your checked out repo. Any furthergit pull
will automatically update the submodules.See #1893.