Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize AlmaMmsId for opac links #1888 #1924

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Prioritize AlmaMmsId for opac links #1888 #1924

merged 2 commits into from
Oct 19, 2023

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Oct 16, 2023 •
edited
Loading

Related to #1888

I talked to @eschackmann to prioritize the opac links.

  1. almaMmsId
  2. zdbId
  3. hbzId

Also I excluded ISSN/ISBN opac link mappings since they are not needed yet. Updated versions of link lists are empty.

@TobiasNx TobiasNx requested a review from dr0i October 16, 2023 14:31
dr0i
dr0i requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the reformatting one cannot identify the real places of change. Could you separate formatting and coding by providing two commits?

@dr0i dr0i assigned TobiasNx and unassigned dr0i Oct 19, 2023
@TobiasNx TobiasNx changed the base branch from master to fixFormatting October 19, 2023 10:43
@TobiasNx TobiasNx force-pushed the 1888-prioritizeAlmaMmsIdAsOpacLink branch from 3266b50 to fbf66de Compare October 19, 2023 10:48
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Oct 19, 2023
@TobiasNx
Copy link
Contributor Author

Done @dr0i but merge #1928 first into the master :)

@TobiasNx
Exclude issn and isbn mappings for opac links #1888
6291551 
Since no only almaMmsId, hbzId and zdbId mappings are provided
@TobiasNx TobiasNx requested a review from dr0i October 19, 2023 12:21
Base automatically changed from fixFormatting to master October 19, 2023 12:31
@TobiasNx
Copy link
Contributor Author

Due to the reformatting one cannot identify the real places of change. Could you separate formatting and coding by providing two commits?

This is done by #1928

@dr0i dr0i merged commit f798719 into master Oct 19, 2023
1 check passed
@dr0i
Copy link
Member

dr0i commented Oct 19, 2023

Will be deployed next Monday.

@dr0i dr0i deleted the 1888-prioritizeAlmaMmsIdAsOpacLink branch October 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0i dr0i dr0i approved these changes

Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasNx @dr0i