Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inCollection for Digibib hbz VK #2021 #2022

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jun 4, 2024

See #2021

FEX Daten decided they want all CZ publication be findable in the Digibib hbz
Verbundkatalog. Since these CZ publications are not part of the genuine NZ we add a new inCollection-statement. It includes NZ+CZ resources.

FEX Daten decided they want all CZ publication be findable in the Digibib hbz
 Verbundkatalog. Since these CZ publications are not part of the genuine NZ we add a new inCollection-statement. It includes NZ+CZ resources.
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test in web/test/tests/IndexIntegrationTest.java?

{ "inCollection.id:\"https\\://nrw.digibib.net/search/hbzvk/\"", /*->*/ 150 },

src/main/resources/alma/fix/relatedRessourcesAndLinks.fix Outdated Show resolved Hide resolved
src/main/resources/alma/fix/relatedRessourcesAndLinks.fix Outdated Show resolved Hide resolved
@TobiasNx TobiasNx requested a review from blackwinter June 4, 2024 12:50
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I still think a query test would be nice, but it's your decision...

@TobiasNx TobiasNx force-pushed the 2021-inCollectionDigibibVk branch from 0c64d83 to a4d344a Compare June 4, 2024 12:56
@TobiasNx TobiasNx requested a review from acka47 June 4, 2024 15:26
@TobiasNx TobiasNx assigned acka47 and unassigned TobiasNx Jun 4, 2024
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jun 4, 2024

@acka47 is this okay for you? We need an additional inCollection-statement for the digiBib Verbundkatalog since they now need NZ as well as CZ resources.

@TobiasNx
Copy link
Contributor Author

@acka47 Is the way I modeled/mapped it okay for you?

  "inCollection" : [ {
    "id" : "https://nrw.digibib.net/search/hbzvk/",
    "label" : "DigiBib hbz Verbundkatalog",
    "type" : [ "Collection" ]
  }

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TobiasNx TobiasNx assigned dr0i and unassigned acka47 Jun 10, 2024
@TobiasNx TobiasNx merged commit d2f6b6c into master Jun 10, 2024
1 check passed
@TobiasNx TobiasNx deleted the 2021-inCollectionDigibibVk branch June 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants