Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: Adjust describedBy properties according to the fix transformation #2025

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Schema: Adjust describedBy properties according to the fix transformation #2025

merged 8 commits into from
Aug 7, 2024

Conversation

maipet
Copy link
Contributor

@maipet maipet commented Jun 5, 2024 •
edited by TobiasNx
Loading

Related to #1340

This PR changes the describedBy schema:

@maipet maipet requested a review from TobiasNx June 5, 2024 10:33
@TobiasNx
Copy link
Contributor

TobiasNx commented Jun 5, 2024 •
edited
Loading

I changed some stuff for modifiedBy.

Ideally test with: $ ajv compile -s '[path/to/schema]' -c ajv-formats

TobiasNx
TobiasNx approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@TobiasNx TobiasNx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now describedBy is valide in all JSON files.

@TobiasNx TobiasNx requested a review from acka47 June 5, 2024 11:30
@TobiasNx TobiasNx mentioned this pull request Jun 5, 2024
Closed
TobiasNx added 3 commits August 2, 2024 10:37
@TobiasNx
Merge remote-tracking branch 'origin/master' into 1340-AdjustDescribe…
d0522c0 
…dByJsonSchema
@TobiasNx
Make dateCreated a required property #1340
8b69006
@TobiasNx
Drop the pattern for provider, sourceOrganization and modifiedBy #1340
f5cc4e1 
This is to allow institutions that are not specified by an ISIL as ebsco or proquest but have OCLC or ALMA institution codes. See
#1438
@TobiasNx
Copy link
Contributor

TobiasNx commented Aug 2, 2024

@maipet I added two commits to this.

@TobiasNx
Adjust schema for spatial #1340
f8da109 
To validate RPB spatial info.
@TobiasNx TobiasNx changed the title Adjust describedBy properties according to the fix transformation Schema: Adjust describedBy properties according to the fix transformation Aug 5, 2024
@TobiasNx
Merge pull request #2040 from hbz/1340-spatial
80d47c7 
Schema: Adjust spatial schema to validate RPB spatial info too.
@TobiasNx
Copy link
Contributor

TobiasNx commented Aug 7, 2024

@acka47 you already reviewed the changes for spatial (last two commits) somehow i did non merge them into master but into this PR/Branch.

acka47
acka47 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating this.

@TobiasNx TobiasNx merged commit d1599ed into master Aug 7, 2024
1 check passed
@TobiasNx TobiasNx deleted the 1340-AdjustDescribedByJsonSchema branch August 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasNx TobiasNx TobiasNx approved these changes

@acka47 acka47 acka47 approved these changes

Assignees

@acka47 acka47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maipet @TobiasNx @acka47