Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBIS refrence #1864 #2056

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add DBIS refrence #1864 #2056

merged 3 commits into from
Aug 22, 2024

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Aug 20, 2024

See #1864

@TobiasNx TobiasNx marked this pull request as ready for review August 20, 2024 13:19
@TobiasNx TobiasNx requested a review from dr0i August 20, 2024 13:19
"id" : "https://d-nb.info/026537966",
"label" : "DNB-Ressource"
"id" : "http://dbis.uni-regensburg.de/frontdoor.php?titel_id=1815",
"label" : "DBIS-Ressource"
}, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1864 (comment) it's said to add a link to DBIS, not to drop the link to dnb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird

Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides of my inline remark: +1

@dr0i dr0i assigned TobiasNx and unassigned dr0i Aug 22, 2024
@TobiasNx TobiasNx requested a review from dr0i August 22, 2024 08:32
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Aug 22, 2024
@TobiasNx
Copy link
Contributor Author

This was an error in the mapping.

@dr0i dr0i merged commit 448ee9a into master Aug 22, 2024
1 check passed
@dr0i dr0i deleted the 1864-dbis branch August 22, 2024 08:44
@dr0i
Copy link
Member

dr0i commented Aug 22, 2024

Will be deployed next Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants