Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch property for Braille text #884

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChristophEwertowski
Copy link
Contributor

Resolves #827

@ChristophEwertowski ChristophEwertowski force-pushed the 827-brailleBookDoesNotResolve branch from 90fed99 to b5912bd Compare July 27, 2018 09:32
@ChristophEwertowski
Copy link
Contributor Author

@fsteeg : The icon for "Blindendruck" doesn't appear in test.lobid.org/resources/search. The resources.conf is adjusted and the test resource TT001210514 has the right icon and label. What did I overlook?

@fsteeg
Copy link
Member

fsteeg commented Jul 27, 2018

I've opened #885 for the underlying label lookup issue.

@fsteeg fsteeg removed their assignment Jul 27, 2018
@dr0i
Copy link
Member

dr0i commented Aug 28, 2018

Assigning @acka47 , please have a look at the Files changed. As there are more added definitions than just the Braille one , and if you agree, we could merge this already to have the data in our index. Icons and other frontend issues can be solved later.

@dr0i dr0i assigned acka47 and unassigned dr0i Aug 28, 2018
@acka47 acka47 removed the review label Apr 9, 2019
@TobiasNx
Copy link
Contributor

@acka47 This PR is quite old and I think we should close it, since it only changes the old morph transformation.

The issue still seems to be valid, the URI for BrailleBook ( http://purl.org/library/BrailleBook) seems to be not resolvable.
@ChristophEwertowski changed the property first to a GND property and then to a lobid vocabs concept "http://purl.org/lobid/lv#Braille". I dont know if we still want to change this but then we should do this in a new PR.

Additionally the changes in cfe256e seem to be valid and could be cherry picked, since they add missing labels to the context labels file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

BrailleBook URL doesn't resolve
5 participants