feat: #6925 - Emoji selection when typing : (colon) symbol in the chat box #6991
Conversation
Signed-off-by: ElSalvo96 <[email protected]>
There was a problem hiding this comment.
[Non-blocking comment]: In this file I have seen 3 eslint-disable-next-line. I do not wanna say do not use it, but rather I prefer to stay safe as much as possible. So for example if the type is an issue I try first to fix that and not use eslint-disable-next-line.
| insertTable (options: { rows?: number, cols?: number, withHeaderRow?: boolean }) { | ||
| insertTable(options: { rows?: number; cols?: number; withHeaderRow?: boolean }) { |
There was a problem hiding this comment.
To me it looks like someones IDE is not configured to format the code properly. Do we need some kind of pipeline to reject unformatted code? Or maybe husky to format the code before push?
There was a problem hiding this comment.
There is no husky in this project.
The file is saved with the prettier-eslint extension. So I think that my new one is right.
There was a problem hiding this comment.
Yeah, I meant that it should be added otherwise these kind of unnecessary changes will be pushed and someone has to code review these kind of changes while we can prevent it simply by adding something like husky. I do not know how ususally thing are done here but if it were up to me I would have created a task called add husky or at least do some R&D around it to find out whether it worth the effort or not.
There was a problem hiding this comment.
Could not we just remove this file?
You know what I mean, it was added in this PR and if it is not needed then should not be here as well.
There was a problem hiding this comment.
Yes I could. I was put there because no one know if in the future is still need to generate the file. With that instead of going into the thought process, you only need to run this script.
In any case, do you believe that deleting it is necessary? It's different approach it depends on how do they usually work.
Let me know
There was a problem hiding this comment.
Hmm, cannot we just doc it instead if it is really something useful somewhere else? Dunno what kind of documentation generating tool we use here but it could go there if you ask me.
|
Hello @kasir-barati, thanks for the review. When I did this feature, I just copied from other components, avoiding editing too much of the logic itself. In any case, I feel that you were right into a lot of the comment. |
Co-authored-by: Mohammad Jawad (Kasir) Barati <[email protected]> Signed-off-by: ElSalvo96 <[email protected]>
Co-authored-by: Mohammad Jawad (Kasir) Barati <[email protected]> Signed-off-by: ElSalvo96 <[email protected]>
Co-authored-by: Mohammad Jawad (Kasir) Barati <[email protected]> Signed-off-by: ElSalvo96 <[email protected]>
Signed-off-by: ElSalvo96 <[email protected]>
About this PR
This PR adds a new feature for selecting emoji when typing a colon in the chat box; for example, typing :joy will show a selection of emoji to choose from.
This PR should close this issue: #6925
The list of emoji is generated from
/platform/plugins/text-editor-resources/src/components/extension/emojiIdMapGenerator.ts, a revisited file from https://github.com/ikatyang/emoji-cheat-sheet/blob/master/scripts/fetch.tsBefore
After
Note: Since this is my first experience using Svelte, I would appreciate any input.