Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-8425: Global accounts #7573

Draft
wants to merge 41 commits into
base: develop
Choose a base branch
from
Draft

UBERF-8425: Global accounts #7573

wants to merge 41 commits into from
+19,181 −18,009

Conversation

lexiv0re
Copy link
Collaborator

@lexiv0re lexiv0re commented Dec 28, 2024 •
edited
Loading

Summary:

  • Gets rid of internal workspace PersonAccount uses
  • Every user is now identified by a list of associated confirmed social identifiers
  • Completely reworks the account service schema to support new entities

Broken parts (haven't been properly adjusted yet):

  • All sort of integrations (Github, Gmail, Telegram)
  • Services: AIBot (including Support workspace), Backup, Stats
  • CF workers

Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-8425

@lexiv0re lexiv0re force-pushed the uberf-8425/global-accounts-sid branch 6 times, most recently from 1b76b91 to 12004d5 Compare January 15, 2025 10:00
@lexiv0re lexiv0re force-pushed the uberf-8425/global-accounts-sid branch 3 times, most recently from 7667228 to 0c2f0d0 Compare January 28, 2025 21:39
@aonnikov aonnikov self-requested a review January 29, 2025 08:35
aonnikov
aonnikov previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aonnikov aonnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through core part, models, interface plugins, and some services (love/collaborator/github).
LGTM

@lexiv0re lexiv0re force-pushed the uberf-8425/global-accounts-sid branch from 0c2f0d0 to e8b20cf Compare January 29, 2025 08:45
lexiv0re added 17 commits January 30, 2025 12:51
@lexiv0re
uberf-8425: global accounts
6a87bc0 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix some lint issues
b2da58f 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix mismatching deps
ed29b93 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: more lint fixes
189ed27 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix CR accounts adapter
3730f26 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: enable cockroach tests
8ee2a80 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: adjustments after merge
3aa5341 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
33c9aef 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes based on CR tests
0d53c4a 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
e584057 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix templates, unit tests
9cbd2f6 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix formatting & CR tests
824ae97 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix unit tests, formatting
315ace4 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: adjust qms tests
86c1f72 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix qms tests
2266d28 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: more qms fixes
59e38e7 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix formatting
506d91a 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
lexiv0re added 24 commits January 30, 2025 12:52
@lexiv0re
uberf-8425: fix svelte check
79e4303 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: use single account client across the platform
aa1d66a 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix qms signature
f5a30c7 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes
fe1407d 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: accounts migration
7dbccfe 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix accounts migration
c54f6a2 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
cbf6939 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: use old dataId for storages, fix migration issues
e4cae11 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix migrations, formatting
434ea42 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
33ae2dd 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix pg table name
17bd120 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix front pod in tests, fix pg account names mapping
8497344 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: epoch timestamps in pg
b72560e 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix formatting
63edb57 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: remove id from social id, use key
395099c 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: strict type checks between various string ids
e40ccce 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix formatting
a75821a 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix otp to social id reference
0b7a433 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix private middleware, pg account schema
7cb3725 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
db4d89e 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix notification, collaboration cursor popup
80c16d5 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix some tests
f9c686f 
Signed-off-by: Alexey Zinoviev <[email protected]>

Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fixes after merge
3184b45 
Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re
uberf-8425: fix archived security
15ec8f1 
Signed-off-by: Alexey Zinoviev <[email protected]>
@lexiv0re lexiv0re force-pushed the uberf-8425/global-accounts-sid branch from e8b20cf to 15ec8f1 Compare January 30, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexiv0re @aonnikov