Allow to disable surveys #9349
Merged
Allow to disable surveys #9349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Bykhov <[email protected]>
|
Connected to Huly®: UBERF-11773 |
There was a problem hiding this comment.
Pull Request Overview
Adds configuration options to disable and describe the survey plugin and updates all locale files with new labels and descriptions.
- Extended the survey plugin’s string definitions with
ConfigLabelandConfigDescription. - Updated each locale JSON to include translations for the new config keys.
- Modified the global model builder to register the survey model with additional metadata (
label,description,enabled,beta,classFilter).
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/survey/src/index.ts | Added ConfigLabel and ConfigDescription properties to strings |
| plugins/survey-assets/lang/zh.json | Added Chinese translations for config label/description |
| plugins/survey-assets/lang/ru.json | Added Russian translations for config label/description |
| plugins/survey-assets/lang/pt.json | Added Portuguese translations for config label/description |
| plugins/survey-assets/lang/ja.json | Added Japanese translations for config label/description |
| plugins/survey-assets/lang/it.json | Added Italian translations for config label/description |
| plugins/survey-assets/lang/fr.json | Added French translations for config label/description |
| plugins/survey-assets/lang/es.json | Added Spanish translations for config label/description |
| plugins/survey-assets/lang/en.json | Added English translations for config label/description |
| plugins/survey-assets/lang/de.json | Added German translations for config label/description |
| plugins/survey-assets/lang/cs.json | Added Czech translations for config label/description |
| models/all/src/index.ts | Imported survey default and registered the model with metadata |
Comments suppressed due to low confidence (2)
plugins/survey/src/index.ts:100
- Consider adding documentation (e.g., README update or docstring) for the new
ConfigLabelandConfigDescriptionkeys to explain their purpose and how they are used in the UI.
ConfigLabel: '' as IntlString,
models/all/src/index.ts:462
- Add or update unit/integration tests to verify that the survey model respects the new
enabled: falseflag and correctly applies the providedlabelanddescriptionmetadata.
{
haiodo
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.