JAX exp scripts #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchings
commented
Feb 7, 2023
|
|
||
| # state, train_metric, dropout_rngs = p_train_step(state, model_inputs, dropout_rngs) | ||
| # Use this line for benchmark | ||
| state, train_metric, dropout_rngs = jax.block_until_ready(p_train_step(state, model_inputs, dropout_rngs)) |
There was a problem hiding this comment.
pmapped functions in JAX run asynchronously, so we need to call block_until_ready to make sure a particular computation has actually finished.
hchings
commented
Feb 7, 2023
| # calculate throughput | ||
| time_elapsed = time.time() - start | ||
| step_time = time.time() - step_start | ||
| sample_processed = len(samples) # same as GBS |
There was a problem hiding this comment.
To my understanding, the len(samples) here is already all the samples processed across all GPUs based on how JAX works (L817 shards all data across 8 GPUs, and then each process “sees” local input and output in parallelized functions). So we don't have to times dp_size as R/H script does:
sample_processed = input_ids.shape[0] * dp_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmp PR for easier code review