Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesis: Add fa/ha extract and techmap pass #253

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

mtdudek
Copy link
Collaborator

@mtdudek mtdudek commented Dec 18, 2023

This commit adds extra extract_fa Yosys pass combined with fa/ha techmapping.
It runs only when user specifies $fa/$ha to DPK mapping.
This commit also adds new adder_mapping attr to the synthesize_rtl rule.
This file provides Yosys with $fa/$ha blackboxes.
This change may affect existing designs, as extra opt pass is being run.

Seventh part of the #243

Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good but nothing seems to use it?

@mithro
Copy link
Member

mithro commented Dec 19, 2023

As described in #239 I'm going to wait a for the other changes to bake for a bit before landing these.

@mtdudek
Copy link
Collaborator Author

mtdudek commented Dec 19, 2023

I'm not sure if I should attach verilog files that are PDK and yosys specific,
so I left it up to the user to provide such mapping.

Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtdudek
Copy link
Collaborator Author

mtdudek commented Dec 20, 2023

I can add them to this folders.
Should I modify PDK provider to also include ha/fa mapping files?

@mithro
Copy link
Member

mithro commented Dec 20, 2023

Should I modify PDK provider to also include ha/fa mapping files?

I assume that is what is needed to get us into the same set up as OpenROAD-flow-scripts?

This commit adds extra `extract_fa` Yosys pass combined
with fa/ha techmapping. It runs only when user specifies
$fa/$ha to DPK mapping.
This commit also adds new `adder_mapping` attr
to the `synthesize_rtl` rule. This file provides
Yosys with $fa/$ha blackboxes.
This change may affect existing designs,
as extra `opt` pass is being run.

Signed-off-by: Maciej Dudek <[email protected]>
This commit adds Yosys fa/ha techmapping file
to the OpenROAD configuration provider.
These files are PDK and Standard cell specific,
so each PDK variant has to provide its own definitions.

Signed-off-by: Maciej Dudek <[email protected]>
This commit adds fa_ha_mapping file to
the Skywater sky130 fd_sc_hd PDK.

Signed-off-by: Maciej Dudek <[email protected]>
This commit adds fa_ha_mapping files to the
ASAP7 R/L/SL PDKs.

Signed-off-by: Maciej Dudek <[email protected]>
@mtdudek
Copy link
Collaborator Author

mtdudek commented Dec 20, 2023

I've added fa/ha mapping files from ORFS and I've modified open_road_configuration
to provide fa/ha mapping file. Doing so I've also rebased branch onto the newest main.

@mithro
Copy link
Member

mithro commented Dec 21, 2023

LGTM!

@mithro mithro merged commit 63cc3d4 into hdl:main Dec 21, 2023
4 checks passed
@mtdudek mtdudek deleted the 52551-adder_mapping_pass branch October 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants