Added incompatibility flag to prepare for flip in future Bazel versions #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
|
Looks like there's some RPM related error https://app.buildbuddy.io/invocation/554468ea-d9a8-11ee-8ecb-0242c0a80a02 |
Yeah, I was definitely wrong when I mentioned the repo looked compliant. But the way the repo is tested is also slightly flawed. It shouldn't be checking |
abrisco
force-pushed
the
incompat
branch
3 times, most recently
from
42ae1ca
to
815834f
Compare
abrisco
commented
Aug 6, 2024
| @@ -30,4 +30,9 @@ def org_gnu_bison(): | |||
| name = "rules_bison", | |||
| sha256 = "2279183430e438b2dc77cacd7b1dbb63438971b2411406570f1ddd920b7c9145", | |||
| urls = ["https://github.com/jmillikin/rules_bison/releases/download/v0.2.2/rules_bison-v0.2.2.tar.xz"], | |||
| patch_args = ["-p1"], | |||
| patches = [ | |||
| # TODO(https://github.com/jmillikin/rules_bison/pull/14): Delete after this PR is merged | |||
There was a problem hiding this comment.
abrisco
force-pushed
the
incompat
branch
7 times, most recently
from
d8b7567
to
10f22ef
Compare
abrisco
force-pushed
the
incompat
branch
2 times, most recently
from
fd8c0ae
to
cc4ad7e
Compare
|
@QuantamHD this change is finally ready for review! |
QuantamHD
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick query seemed to prove the repo is compliant with
incompatible_disallow_empty_globbut it'd be good to add regardless to avoid future regressions.closes #344