-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use BuildTheDocs, add CI workflow #2
base: main
Are you sure you want to change the base?
Conversation
39fef77
to
d952c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the biggest issues with the documentation on this fork is references to pip install hdlparse
since I believe this will pull Kevin's repo and version 1.0.4. We'll have to make our repo's package available on PyPI. We can also consider changing the name of modules to pyhdlparse to prevent installation issues.
|
||
> pip install setuptools | ||
|
||
The easiest way to install pyHDLParser is from `PyPI <https://pypi.python.org/pypi/hdlparse>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume one ticket of order is uploading a new package on PyPI. We should also consider changing the module names from hdlparse
to pyhdlparse
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented below, I agree. However, we need to decide which namespace to use in PyPI, and modify the Symbolator dependencies accordingly.
You can access the Hdlparse Git repository from `Github | ||
<https://github.com/kevinpt/hdlparse>`_. You can install direct from PyPI with the "pip" | ||
command if you have it available. | ||
You can access the Hdlparse Git repository from `Github <https://github.com/hdl/pyHDLParser>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
external URLs need 2x _
at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I did not review the rst syntax. I did:
- Add
.btd.yml
, CI workflow and adaptconf.py
for using the sphinx_btd_theme.- Remove sources for customising the previous theme (alabaster).
- Split the
index.rst
into multiple.rst
files and use atoctree
to have the sidebar populated in the sphinx_btd_theme. - Add a
genindex.rst
placeholder and use it in the toctree. - Replace
kevinpt/hdlparse
withhdl/pyHDLParser
andHdlparse
withpyHDLParser
; but not the references to PyPI. - Break lines at max 120 chars.
The content of the README.rst is actually duplicated in the docs. We should probably remove most of the content from this file, and fix the syntax in getting.rst
(see https://github.com/hdl/pyHDLParser/pull/2/files#diff-d6d6b4e691a98ef7d987710f8d3aeeed8eafecfbdfe0b990ece4d2a9bf81a347R16).
@michael-etzkorn you are correct about the naming, pip, etc. I did not change that on purpose. Let me explain:
|
Store port line comments
89b0f20
to
c19e1f0
Compare
@umarcor converted this to a draft as it's not yet ready for review, right? |
This PR adds a CI workflow for building the docs and pushing to gh-pages automatically, using the BuildTheDocs Action and theme.