Revert 1140 optional scipy #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move scipy to optional requirements * Update changelog * Add test for missing scipy importerror * Fix test
This reverts commit 1fef7e5.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1147 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 42 42
Lines 9524 9524
Branches 1921 1921
=======================================
Hits 8655 8655
Misses 576 576
Partials 293 293 ☔ View full report in Codecov by Sentry. |
|
I think this is not necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
How to test the behavior?
Checklist
CHANGELOG.mdwith your changes?