Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_key to support multiple keys #999

Merged
merged 7 commits into from
Dec 9, 2023
Merged

Update get_key to support multiple keys #999

merged 7 commits into from
Dec 9, 2023

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Nov 15, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

This is the continuation of PR #964. Update the get_key method to return all the keys if there are multiple (instead of returning an error.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97260bc) 88.57% compared to head (68fb02e) 88.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #999      +/-   ##
==========================================
- Coverage   88.57%   88.57%   -0.01%     
==========================================
  Files          45       45              
  Lines        9503     9502       -1     
  Branches     2702     2703       +1     
==========================================
- Hits         8417     8416       -1     
  Misses        764      764              
  Partials      322      322              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review November 21, 2023 16:21
@mavaylon1 mavaylon1 requested a review from rly December 4, 2023 18:11
@mavaylon1 mavaylon1 merged commit f95b1ef into dev Dec 9, 2023
26 checks passed
@mavaylon1 mavaylon1 deleted the getkey branch December 9, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants