(#4) Added option to Include File URL in schema. #5
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just using it now, I have more stuff to do since it's not working the best. There was a typing error and the options wasn't getting passed down, I fixed both of them, but I just stumbled on another error. |
|
I want to preface that this is not ready to merge. I just need a go-ahead before I spend some time to patch up this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the issue I made (#4):
I added a potential option that allows the File URLS to be removed from the schema, the Firebase DAM, for example, came with an authorization token in the URL that allows anyone to view it despite the rules set. I've only edited the Firebase DAM to have the option to include File URL.
I couldn't test this on a running sanity website, though I plan to try on Monday.
This is a small, non-breaking change.
I'm open for suggestions. Also, I should also add a guide on README.md about the new option.