Fix tab names not displaying #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from leaf.getViewState() in getFilename and getDirname, and remove file extensions from tab names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by extracting filenames and directories from leaf.getViewState() in getFilename and getDirname, and remove file extensions from tab names.
Hello, I created this issue today and also managed to solve it by updating the Tabs.svelte file. I am not proficient in JavaScript but managed to resolve this through some trial & error, (docs) as well as ChatGPT.
I was not able to replicate your build because I couldn't install the TypeScript version you have but I made some adjustments in main and created my own build. With the fixed versions of getFilename and getDirname, the issue seems to be resolved. I tested it in 2 desktop vaults and one mobile vault by replacing the main.js there.
I hope this works the same way with you build.
Best,
Leon