frontend: PluginSettings rework

Signed-off-by: Vincent T <[email protected]>
headlamp-k8s · Dec 12, 2024 · 56e912f · 56e912f
1 parent d0eea72
commit 56e912f
Show file tree

Hide file tree

Showing 3 changed files with 95 additions and 13 deletions.
diff --git a/frontend/src/components/App/PluginSettings/PluginSettings.tsx b/frontend/src/components/App/PluginSettings/PluginSettings.tsx
@@ -8,7 +8,7 @@ import { useTranslation } from 'react-i18next';
 import { useDispatch } from 'react-redux';
 import helpers from '../../../helpers';
 import { useFilterFunc } from '../../../lib/util';
-import { PluginInfo, reloadPage, setPluginSettings } from '../../../plugin/pluginsSlice';
+import { PluginInfo, reloadPage } from '../../../plugin/pluginsSlice';
 import { useTypedSelector } from '../../../redux/reducers/reducers';
 import { Link as HeadlampLink, SectionBox, Table } from '../../common';
 import SectionFilterHeader from '../../common/SectionFilterHeader';
@@ -285,11 +285,85 @@ export default function PluginSettings() {
 
   const pluginSettings = useTypedSelector(state => state.plugins.pluginSettings);
 
+  const [plugins, setPlugins] = useState<PluginInfo[]>([]);
+
+  const [pluginsIsEnabled, setPluginsIsEnabled] = useState<any>([]);
+
+  useEffect(() => {
+    async function get() {
+      const pluginPaths = (await fetch(`${helpers.getAppUrl()}plugins`).then(resp =>
+        resp.json()
+      )) as string[];
+      const packageInfosPromise = await Promise.all<PluginInfo>(
+        pluginPaths.map(path =>
+          fetch(`${helpers.getAppUrl()}${path}/package.json`).then(resp => {
+            if (!resp.ok) {
+              if (resp.status !== 404) {
+                return Promise.reject(resp);
+              }
+              {
+                console.warn(
+                  'Missing package.json. ' +
+                    `Please upgrade the plugin ${path}` +
+                    ' by running "headlamp-plugin extract" again.' +
+                    ' Please use headlamp-plugin >= 0.8.0'
+                );
+                return {
+                  name: path.split('/').slice(-1)[0],
+                  version: '0.0.0',
+                  author: 'unknown',
+                  description: '',
+                };
+              }
+            }
+            return resp.json();
+          })
+        )
+      );
+      const packageInfos = await packageInfosPromise;
+      // setPlugins(packageInfos);
+      console.log('package', packageInfos);
+
+      // const pluginsWithIsEnabled = plugins.map(plugin => {
+      //   const isEnabledInfo = pluginSettings.find(it => it.name === plugin.name);
+
+      //   let isEnabled;
+      //   if (!isEnabledInfo) {
+      //     isEnabled = true;
+      //   } else {
+      //     isEnabled = isEnabledInfo.isEnabled;
+      //   }
+      //   return {
+      //     ...plugin,
+      //     isEnabled: isEnabled,
+      //   };
+      // });
+
+      const pluginsWithIsEnabled = packageInfos.map(plugin => {
+        const matchedSetting = pluginSettings.find(p => plugin.name === p.name);
+        if (matchedSetting) {
+          return {
+            ...plugin,
+            isEnabled: matchedSetting.isEnabled,
+          };
+        }
+        return plugin;
+      });
+
+      setPlugins(pluginsWithIsEnabled);
+
+      console.log('pluginsWithIsEnabled', pluginsWithIsEnabled);
+      setPluginsIsEnabled(pluginsWithIsEnabled);
+    }
+    get();
+  }, []);
+
+  console.log('END PLUGIN DATA', plugins);
+  console.log('ENABLED', pluginsIsEnabled);
   return (
     <PluginSettingsPure
-      plugins={pluginSettings}
-      onSave={plugins => {
-        dispatch(setPluginSettings(plugins));
+      plugins={plugins}
+      onSave={() => {
         dispatch(reloadPage());
       }}
     />

diff --git a/frontend/src/plugin/index.ts b/frontend/src/plugin/index.ts
@@ -199,17 +199,20 @@ export function filterSources(
  */
 export function updateSettingsPackages(
   backendPlugins: PluginInfo[],
-  settingsPlugins: PluginInfo[]
+  settingsPlugins: { name: string; isEnabled: boolean }[]
 ): PluginInfo[] {
   if (backendPlugins.length === 0) return [];
 
   const pluginsChanged =
     backendPlugins.length !== settingsPlugins.length ||
-    backendPlugins.map(p => p.name + p.version).join('') !==
-      settingsPlugins.map(p => p.name + p.version).join('');
+    backendPlugins.map(p => p.name) !== settingsPlugins.map(p => p.name);
 
   if (!pluginsChanged) {
-    return settingsPlugins;
+    const updatedPlugins = backendPlugins.filter(plugin =>
+      settingsPlugins.some(setting => setting.name === plugin.name)
+    );
+
+    return updatedPlugins;
   }
 
   return backendPlugins.map(plugin => {
@@ -241,7 +244,7 @@ export function updateSettingsPackages(
  *
  */
 export async function fetchAndExecutePlugins(
-  settingsPackages: PluginInfo[],
+  settingsPackages: { name: string; isEnabled: boolean }[],
   onSettingsChange: (plugins: PluginInfo[]) => void,
   onIncompatible: (plugins: Record<string, PluginInfo>) => void
 ) {

diff --git a/frontend/src/plugin/pluginsSlice.ts b/frontend/src/plugin/pluginsSlice.ts
@@ -91,7 +91,7 @@ export interface PluginsState {
   /** Have plugins finished executing? */
   loaded: boolean;
   /** Information stored by settings about plugins. */
-  pluginSettings: PluginInfo[];
+  pluginSettings: { name: string; isEnabled: boolean }[];
 }
 const initialState: PluginsState = {
   /** Once the plugins have been fetched and executed. */
@@ -110,9 +110,14 @@ export const pluginsSlice = createSlice({
     /**
      * Save the plugin settings. To both the store, and localStorage.
      */
-    setPluginSettings(state, action: PayloadAction<PluginInfo[]>) {
-      state.pluginSettings = action.payload;
-      localStorage.setItem('headlampPluginSettings', JSON.stringify(action.payload));
+    setPluginSettings(state, action: PayloadAction<any[]>) {
+      const pluginInfo = action.payload.map(p => ({
+        name: p.name,
+        isEnabled: p.isEnabled,
+      }));
+      state.pluginSettings = pluginInfo;
+      console.log('LOCAL SAVE', pluginInfo);
+      localStorage.setItem('headlampPluginSettings', JSON.stringify(pluginInfo));
     },
     /** Reloads the browser page */
     reloadPage() {