Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pvc without storage class #1432

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

joaquimrocha
Copy link
Collaborator

fixes #1431

How to test:

  • Create a PVC with a blank ("") storage class name set to it and go to the list view: it should work
    (or check the storybook for it)

@joaquimrocha joaquimrocha requested a review from ashu8912 October 4, 2023 14:16
@joaquimrocha joaquimrocha force-pushed the fix-pvc-without-storage-class branch from d203744 to 0f46897 Compare October 4, 2023 15:12
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, let's wait for the CI to pass otherwise the code LGTM

@joaquimrocha joaquimrocha merged commit 0f09b81 into main Oct 5, 2023
6 checks passed
@joaquimrocha joaquimrocha deleted the fix-pvc-without-storage-class branch October 5, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank page for /c/main/storage/persistentvolumeclaims when no namespace is selected
2 participants