Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: redux/filterSlice: Refactor filter reducers/actions into slice #1445

Merged
merged 1 commit into from
Oct 12, 2023
Merged

frontend: redux/filterSlice: Refactor filter reducers/actions into slice #1445

merged 1 commit into from
Oct 12, 2023

Conversation

illume
Copy link
Collaborator

@illume illume commented Oct 10, 2023 •
edited
Loading

  • Moved related filter functionality from lib/util and actions/reducers files into redux/filterSlice
  • Added some docs.
  • Added some tests.

How to test?

  • Use the filters, including the namespace filters. They should work as before.

Part of #1159 epic.

@illume illume force-pushed the filter-redux-toolkit branch from 13790c5 to 4864d9d Compare October 10, 2023 09:50
@illume illume added the frontend Issues related to the frontend label Oct 10, 2023
@illume illume marked this pull request as draft October 10, 2023 09:59
@illume
frontend: redux/filterSlice: Refactor filter reducers/actions into slice
48fa206 
Moved related filter functionality from lib/util into there too.

There's also some tests in filterSlice.test.ts now.

Signed-off-by: René Dudfield <[email protected]>
@illume illume force-pushed the filter-redux-toolkit branch from 4864d9d to 10ef408 Compare October 10, 2023 14:44
@illume illume marked this pull request as ready for review October 10, 2023 15:28
@illume illume requested review from ashu8912 and vyncent-t October 10, 2023 16:58
@illume illume force-pushed the filter-redux-toolkit branch from 10ef408 to 48fa206 Compare October 10, 2023 17:58
@joaquimrocha joaquimrocha merged commit 43a25c5 into main Oct 12, 2023
6 checks passed
@joaquimrocha joaquimrocha deleted the filter-redux-toolkit branch October 12, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

@ashu8912 ashu8912 Awaiting requested review from ashu8912

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees
No one assigned
Labels
frontend Issues related to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illume @joaquimrocha