Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-ext: Fix portforward issue #1488

Merged
merged 1 commit into from
Oct 30, 2023
Merged

docker-ext: Fix portforward issue #1488

merged 1 commit into from
Oct 30, 2023

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Oct 23, 2023 •
edited
Loading

In docker desktop since the backend is running
inside a container portforwards running in the
container are not accessible from the host machine
to fix this a range of ports from 30000 to
32000 is exposed and a value in this range is used
when starting a portforward.

@yolossn yolossn requested a review from ashu8912 October 23, 2023 04:55
@yolossn yolossn force-pushed the port-forward-dd-fix branch from 05d7da0 to e120aa2 Compare October 23, 2023 05:04
ashu8912
ashu8912 reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code overall looks good to me Thanks, but can you please explain in the commit a bit more about what we are trying to do here and what ports are exposed etc.

@yolossn
docker-ext: Fix portforward issue
c90688b 
In docker desktop since the backend is running
inside a container portforwards running in the
container are not accessible from the host machine
to fix this a range of ports from 30000 to
32000 is exposed and a value in this range is used
when starting a portforward.

Signed-off-by: yolossn <[email protected]>
@yolossn yolossn force-pushed the port-forward-dd-fix branch from e120aa2 to c90688b Compare October 30, 2023 05:16
@yolossn yolossn requested a review from ashu8912 October 30, 2023 05:16
ashu8912
ashu8912 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with help from @yolossn this LGTM

@yolossn yolossn merged commit 0ee663e into main Oct 30, 2023
8 checks passed
@yolossn yolossn deleted the port-forward-dd-fix branch December 18, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashu8912 ashu8912 ashu8912 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yolossn @ashu8912