-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Fix notifications format styles #1674
Conversation
2c0e2cb
to
005f66e
Compare
4a06533
to
3bb8730
Compare
3bb8730
to
d4bffe8
Compare
d4bffe8
to
29606e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR approach has an issue with cutting off parts of the table. See the screenshot below:
I think we can accomplish a good result with a less engineered effort here. Namely by using gridTemplate:
for each column as adequate. The text column should just have auto
so it expands, and the rest should have a min-content
.
The div around the text column should not have the width={'30vw'}
, otherwise it looks artificially cut.
Signed-off-by: Vincent T <[email protected]>
29606e6
to
66e3570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The mobile version is not functional but we should fix that in a different occasion anyway.
Enhancements to Notifications List View for Better UX
Solves issue #1667
Description
This PR focuses on improving the user experience of the Notifications List View. It involves utilizing the available horizontal space more effectively to display a larger portion of the notification message. Additionally, the cluster name in each notification will now be a clickable link, redirecting users directly to the associated cluster.
Changes
Verification
Screenshots