Add Plugin Settings Detail View and Plugin Config Store #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yolossn
force-pushed
the
plugin_config
branch
2 times, most recently
from
c9265e5 to
ef90abd
Compare
yolossn
requested review from
illume,
ashu8912 and
joaquimrocha
and removed request for
illume and
ashu8912
yolossn
force-pushed
the
plugin_config
branch
from
ef90abd to
067fa3c
Compare
joaquimrocha
requested changes
Feb 1, 2024
frontend/src/components/App/PluginSettings/pluginSettingsDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/App/PluginSettings/pluginSettingsDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/App/PluginSettings/pluginSettingsDetail.tsx
Outdated
Show resolved
Hide resolved
yolossn
force-pushed
the
plugin_config
branch
from
067fa3c to
68f3fb7
Compare
knrt10
reviewed
Feb 6, 2024
frontend/src/components/App/PluginSettings/pluginSettingsDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/App/PluginSettings/pluginSettingsDetail.tsx
Outdated
Show resolved
Hide resolved
illume
requested changes
Feb 6, 2024
yolossn
force-pushed
the
plugin_config
branch
5 times, most recently
from
fda3ee5 to
0d2d8ea
Compare
yolossn
force-pushed
the
plugin_config
branch
2 times, most recently
from
167bb59 to
8a71f4b
Compare
yolossn
force-pushed
the
plugin_config
branch
from
8a71f4b to
80357b9
Compare
|
Backend Code coverage changed from 55.5% to 56.1%. Change: .6% 😃. |
yolossn
force-pushed
the
plugin_config
branch
from
6fb6fea to
7d92c68
Compare
|
Backend Code coverage changed from 55.5% to 56.1%. Change: .6% 😃. |
yolossn
force-pushed
the
plugin_config
branch
from
7d92c68 to
3c4ca51
Compare
|
Backend Code coverage changed from 55.5% to 56.2%. Change: .7% 😃. |
joaquimrocha
requested changes
Feb 28, 2024
frontend/src/components/App/PluginSettings/PluginSettingsDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/App/PluginSettings/PluginSettingsDetails.tsx
Outdated
Show resolved
Hide resolved
this patch adds plugin config store that is responsible for handling the storage and retrieval of plugin configs Signed-off-by: yolossn <[email protected]>
this patch adds deletePlugin function to apiProxy, it calls the delete plugin endpoint with all necessary headers to handle auth. Signed-off-by: yolossn <[email protected]>
this patch updates the plugin settings view, filter is added to the table, Origin now can be configured to link to a custom URL and enable buttons UI is improved. Signed-off-by: yolossn <[email protected]>
this commit adds PluginDetails page and storybook for it. Signed-off-by: yolossn <[email protected]>
this patch adds plugin settings component which can be used by the user to configure custom logo by providing the URL. Signed-off-by: yolossn <[email protected]>
this patch registers a Settings Detail Component which allows the user to set the error message to be displayed when the pods count cannot be retrieved. Signed-off-by: yolossn <[email protected]>
this patch adds docs for registerPluginSettings and its related types. Signed-off-by: yolossn <[email protected]>
this patch makes the plugin settings available in all modes, earlier it wasn't available in in-cluster mode. Signed-off-by: yolossn <[email protected]>
yolossn
force-pushed
the
plugin_config
branch
from
3c4ca51 to
848a90c
Compare
|
Backend Code coverage changed from 55.4% to 56.0%. Change: .6% 😃. |
joaquimrocha
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
I think this LGTM now.
BTW, I thought the "now enabled" routes were initially added here and that was a mistake as you mentioned @yolossn . But making the routes available does mean users will see the "disable" button, and I think disabling plugins shouldn't work unless in the app mode.
This can be added in a second PR, but maybe it's important to have it for the release?
WDYT @illume ?
A check is added to make sure the Delete plugin is only visible in the app mode. So the button wont be visible to the user. And similarly check is added in the backend to make sure the delete API route isn't available in the in-cluster mode. |
illume
changed the title
illume
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Plugin Settings Details View and Plugin Config Store that can be used by plugin developers to store and retrieve plugin configurations.
To Do:
Demo:
https://github.com/headlamp-k8s/headlamp/assets/22731013/8a43a75c-014c-4884-b641-ca9d5396b3be
How to test:
change-logoandpod-counterplugins.