Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix default sorting column for the ResourceTable #1685

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

joaquimrocha
Copy link
Collaborator

The ResourceTable by default sorts data by the age column. However,
since the columns can now be hidden, the way to compute the index of
the age column needed to be updated to take hidden columns into
account.

The ResourceTable by default sorts data by the age column. However,
since the columns can now be hidden, the way to compute the index of
the age column needed to be updated to take hidden columns into
account.

Signed-off-by: Joaquim Rocha <[email protected]>
Copy link
Contributor

@vyncent-t vyncent-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vyncent-t vyncent-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@illume illume merged commit 4d22277 into main Feb 1, 2024
9 checks passed
@illume illume deleted the fix-col-sorting branch February 1, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants