frontend: fix stream function for websocket conn #1688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When called stream function was calling connect function synchronously and returning cancel and getSocket which were always null. This converts the function to a async function and returns a promise which resolves to the desired values for both getSocket and cancel function. Co-authored-by: Ashu Ghildiyal <[email protected]> Signed-off-by: Kautilya Tripathi <[email protected]>
joaquimrocha
requested changes
Feb 1, 2024
There was a problem hiding this comment.
I don't understand exactly these changes. Seems like the problem is that getSocket() may return null, but throughout the code that seems to be expected and even accounted for. See e.g. the comment on Termina.tsx:143 (We should only send data if the socket is ready). The solution itself in this PR also seems a bit hacky.
So, even if this fixes things, I would like for a deeper look into the issue and understand exactly whether this is a case where the caller needs to take extra measures.
|
Make sense. I discussed this with @ashu8912 and we agreed that having a socket ready should be in the scope of user. So closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called stream function was calling connect function synchronously and returning cancel and getSocket which were always null. This converts the function to a async function and returns a promise which resolves to the desired values for both getSocket and cancel function.