Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Dockerfile: Fix .plugins copying and usage with test #1692

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Feb 2, 2024

At some point the .plugin package copying stopped working.
It's documented that a .plugins folder will be copied and used by the container.

There's a test included proving that the files are copied properly now.
Fixes #1687

@illume illume added bug Something isn't working plugins regression Bugs for things that used to work in previous releases. labels Feb 2, 2024
@illume illume force-pushed the plugins-copy branch 6 times, most recently from 6c3fb26 to ecda1be Compare February 2, 2024 22:15
At some point the .plugins package copying stopped working.
It's documented that a .plugins folder will be copied and used
by the container.

Signed-off-by: René Dudfield <[email protected]>
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one question, rest LGTM. Nice work :-)

Dockerfile Show resolved Hide resolved
@illume illume force-pushed the plugins-copy branch 8 times, most recently from 1a717d8 to 095bcdc Compare February 5, 2024 12:12
@illume illume added the container Container image Dockerfile related label Feb 5, 2024
@illume illume merged commit 06660f0 into main Feb 5, 2024
10 checks passed
@illume illume deleted the plugins-copy branch February 5, 2024 12:29
@joaquimrocha joaquimrocha added this to the v0.23.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working container Container image Dockerfile related plugins regression Bugs for things that used to work in previous releases.
Projects
Development

Successfully merging this pull request may close these issues.

.plugins folder not copied when creating an image
3 participants