Fix item crud when changing clusters #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the cluster actions are implemented, the actual functions, like update/delete, are only called at the end of the grace period. Since that is also when the cluster name would be gathered, then it could happen that the user changed clusters, and thus this could lead to updating/deleting a resource in a cluster that is different from the intended one (if a similar resource exists). This patch solves this by adding the cluster name to which a resource belongs as an inner member of that resource instance. This cluster name is then used for the mentioned operations, hence guaranteeing that the operations always happen for the same cluster that the item belongs to. Signed-off-by: Joaquim Rocha <[email protected]>
When using the creation dialog to create a resource, due to the fact that the creation function only checked the current cluster after the grace period ends, it may happen that the user changed to a different cluster and thus the change would be applied to a different cluster from what was desired. This patch fixes that by getting the cluster right from the moment the user clicks Apply, so even if clusters are changed, the resources are applied on the intended cluster. Signed-off-by: Joaquim Rocha <[email protected]>
|
@farodin91 , can you test this one too? |
|
@joaquimrocha I will try to check it on monday. |
|
@joaquimrocha Works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes #1660 by making the cluster name as part of each resource instance and using it for the operations (+ something similar for the resource creation).
fixes #1660
How to test: