Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix visibility of Sidebar Elements and Navigation Tabs #1720

Conversation

tazo90
Copy link
Contributor

@tazo90 tazo90 commented Feb 15, 2024

This PR fixes #1719 .

Problem 1: Sidebar elements not visible

Before:
sidebar-before

After:
sidebar-after


Problem 2: Invisible Navigation Tabs

Before:
navigation-tabs-before

After:
navigation-tabs-after

@tazo90 tazo90 force-pushed the fix/1719-sidebar-and-topbar-mobile-fixes branch from ea4c0dd to 63c60b4 Compare February 15, 2024 22:59
@tazo90 tazo90 force-pushed the fix/1719-sidebar-and-topbar-mobile-fixes branch from 830a907 to bba6366 Compare February 19, 2024 23:02
@tazo90 tazo90 force-pushed the fix/1719-sidebar-and-topbar-mobile-fixes branch from bdbd6b5 to e500d42 Compare February 21, 2024 18:35
@joaquimrocha
Copy link
Collaborator

Hey @tazo90 , thanks for this PR. I have noticed that the logo looks broken with it though (maybe due to the updates we had in the meanwhile):
screenshot

I will review the code now.

Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @tazo90 . I left some comments on how to improve this PR.

@@ -31,6 +31,7 @@ import VersionButton from './VersionButton';
export const drawerWidth = 240;
export const mobileDrawerWidth = 320;
export const drawerWidthClosed = 64;
export const topBarHeight = 64;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the sidebar is set from the top of the screen, without having the toolbar before it.
A more future-proof way of fixing this issue is to see what the normal case is doing: Adding a Box with the toolbar style mixin (look for the use of the toolbar class).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have the frequent namespace. Only glossary + translation (default).

@tracetechnical
Copy link

@tazo90 , have you had any more time to work on this? Really excited for this PR to get in so that headlamp is usable on mobile for me

@joaquimrocha
Copy link
Collaborator

@tazo90 , if you don't have time to work on this PR, we understand and we can take it from here. Please let us know.

@joaquimrocha
Copy link
Collaborator

Closing in favor of #2062 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Sidebar elements and Navigation tabs not visible
3 participants