Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Node: Fix table columns and empty values #2604

Merged
merged 1 commit into from
Dec 6, 2024
Merged

frontend: Node: Fix table columns and empty values #2604

merged 1 commit into from
Dec 6, 2024

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Nov 22, 2024 •
edited
Loading

This change adjusts the width of the table columns to prevent UI issues and fills in empty values where applicable.

Fixes: #2100

Testing

  • Open Headlamp in cluster and navigate to the Nodes page
  • Ensure that all empty fields are filled with "None" and columns with the info icon have sufficient spacing.

image

@skoeva skoeva added frontend Issues related to the frontend Table Table component issues labels Nov 22, 2024
@skoeva skoeva requested a review from a team November 22, 2024 21:39
@skoeva skoeva self-assigned this Nov 22, 2024
@skoeva skoeva linked an issue Nov 22, 2024 that may be closed by this pull request
nodes table looks cut off #2100
Closed
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2024
joaquimrocha
joaquimrocha reviewed Nov 27, 2024
View reviewed changes
@skoeva skoeva force-pushed the node-info-bug branch 2 times, most recently from 08e45dc to ab58aad Compare December 2, 2024 18:30
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@skoeva skoeva force-pushed the node-info-bug branch 3 times, most recently from 96f22cc to b04d411 Compare December 6, 2024 15:53
@joaquimrocha joaquimrocha added this to the v0.27.0 milestone Dec 6, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 6, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 6, 2024
@skoeva
frontend: Node: Fix table columns and empty values
7a92511 
This change adjusts the width of the table columns to prevent UI issues
and fills in empty values where applicable.

Fixes: #2100

Signed-off-by: Evangelos Skopelitis <[email protected]>
@joaquimrocha joaquimrocha merged commit 9928715 into main Dec 6, 2024
17 of 18 checks passed
@joaquimrocha joaquimrocha deleted the node-info-bug branch December 6, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees

@skoeva skoeva

Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. Table Table component issues
Projects
Release Plan / Roadmap
Status: Done
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.

nodes table looks cut off
2 participants
@skoeva @joaquimrocha