frontend: Details page blinking fixes #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
sniok
added
frontend
sniok
force-pushed
the
details-blinking-fix
branch
from
dfec57a to
75c0b14
Compare
dosubot
bot
added
the
size:M
Signed-off-by: Oleksandr Dubenko <[email protected]>
When new data is passed in the SimpleTable there's a special case of preventing an update to not disturb user flow but when it's first page the data will always be updated but the Refresh button is still shown for one frame Signed-off-by: Oleksandr Dubenko <[email protected]>
…t layout shift Signed-off-by: Oleksandr Dubenko <[email protected]>
sniok
force-pushed
the
details-blinking-fix
branch
from
75c0b14 to
2e260fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2627 was merged I've noticed some blinking that was happening when navigating to details page from the list page
This PR adds 2 fixes, one for AuthVisible query key and another for the simple table
How to test:
Navigate to Pods
Click on any Pod
No blinking/layout shifting should occur
AuthVisible fix adjust how the key for the query is defined. Previously it was passing the whole object into the key which wasn't very deterministic and would request auth again sometimes even if the object is the same.
The SimpleTable fix is described in the commit message