-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-catalog: UI papercuts #149
Comments
can take a look at these |
I can open an issue for the settings button and the back button, those will need a refactor to get fixed. the rest should be good in #150 |
not sure about the part for the box button styling, I had originally used a boxed button but had feedback to change it early on to what it looks like now, maybe we can check in w/ @joaquimrocha to see if we can convert him to be a box enjoyer too 😉 |
also worth mentioning there has been some shifts for the way styles are done for this plugin, mainly changing away from using the style prop to the sx prop (see the current install button for the list view and then the details view, list view uses sx and details is still on style, causing that color issue) |
Here are some small UI issues found during testing
Settings button 'floats' and is not clear that it is a button
App icon overlaps the text
Hovering install button makes it unreadable
Normal
![Image](https://private-user-images.githubusercontent.com/4517681/406062571-d6aa1d9b-8e26-4b43-80fb-eb8cb8aea1cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjAzODQsIm5iZiI6MTczOTQyMDA4NCwicGF0aCI6Ii80NTE3NjgxLzQwNjA2MjU3MS1kNmFhMWQ5Yi04ZTI2LTRiNDMtODBmYi1lYjhjYjhhZWExY2YucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMDQxNDQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGFjMDA0YzhhYzQ0NTY4Y2Q2NjMyOWNiYmIxZTQ5ZWMwNWMwOTZhNjE2ZDBlY2E1YWMzYWQ5MTQ5YzM0M2YyYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ErQTNffI6lcvq3U9zvlnv0echLNTOLbw3-DzIcAm7bM)
Hover
![Image](https://private-user-images.githubusercontent.com/4517681/406062607-869e9f73-e06e-4070-be44-999eacff4d72.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjAzODQsIm5iZiI6MTczOTQyMDA4NCwicGF0aCI6Ii80NTE3NjgxLzQwNjA2MjYwNy04NjllOWY3My1lMDZlLTQwNzAtYmU0NC05OTllYWNmZjRkNzIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMDQxNDQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzVmYzE1NjMzZDBmYzU2NGRhNzMwMzgyZDVkZWY2ZjUxMTk2NDFjZjVjZjFmZjAzY2RmZTBmMTE0M2NhN2Q4YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ezDci9wKllHgWLErSHpwtnSzDbIo0TI5KgaXwsvUZDA)
Typing into search makes the whole UI 'bounce'
Also note how Categories dropdown rerenders
Recording.2025-01-23.151529.mp4
After clicking on Settings page doesn't have a back button
After clicking on pagination page button focus always goes to the Search field
The text was updated successfully, but these errors were encountered: