-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-catalog: Fix UI bugs #150
Conversation
1d8d7ef
to
ff022fc
Compare
Thanks for taking a look into this! The install button turns light-blue on hover, let's keep it consistent with other black buttons we have in the app. For example here's how cluster chooser button looks while hovered When typing into the search the whole page freezes up, it sends a request and rerenders everything on each key press CPU profiler shows this I'd suggest adding some form debouncing to I know this wasn't in the original issue but I've noticed that sometimes images are missing, looking at the url there's an |
3d4f2f1
to
e9e1080
Compare
@sniok thanks for the input here, added those changes to the PR 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
@skoeva let's rebase and I'll merge this |
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
56cee9d
to
a8bad8e
Compare
Signed-off-by: Evangelos Skopelitis <[email protected]>
@sniok added an additional commit because the app would crash without setting the params, but should be good now |
These changes address minor bugs in the app catalog UI.
Fixes: #149