Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-catalog: fix and updates cards styles #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vyncent-t
Copy link
Contributor

@vyncent-t vyncent-t commented Dec 6, 2024

Description

This PR fixes a bug in the App-Menu plugin that caused singular cards to render squished. The issue affected the visual appearance and usability of the cards, especially when only one card was present.

Key Changes

  1. Fixed Card Rendering:

    • Updated the rendering logic to ensure singular cards display correctly without being squished.
    • Improved the layout to make card sizes consistent regardless of the number of cards.
  2. Improved Card Sizing:

    • Adjusted the size and spacing of cards to enhance the overall user experience.
    • Ensured that the layout remains visually appealing across various card counts and screen sizes.

Images

Before
image

After
image


Steps to Test

  1. Navigate to the App-Menu plugin in the application.
  2. Test the rendering of cards in the following scenarios:
    • Search for Headlamp and filter
  3. Verify:
    • Singular cards display properly without being squished.
    • Card sizes are consistent and align correctly across different layouts.

@vyncent-t vyncent-t added the bug Something isn't working label Dec 6, 2024
@vyncent-t vyncent-t self-assigned this Dec 6, 2024
@vyncent-t vyncent-t force-pushed the fix-app-catalog-default branch from 02a0d55 to 817f73d Compare December 9, 2024 15:29
@vyncent-t
Copy link
Contributor Author

last push fixes the resize for md view point to show double cards before moving to single cards when on sm

Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some style attributes still. Should those be turned into sx?

@vyncent-t vyncent-t force-pushed the fix-app-catalog-default branch from 817f73d to 0e70334 Compare December 12, 2024 17:23
@vyncent-t
Copy link
Contributor Author

updated all the style tags to use sx, not noticing any differences on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants