Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-manager plugin #143

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add cert-manager plugin #143

merged 1 commit into from
Feb 21, 2025

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Dec 30, 2024

Testing the Cert-Manager Plugin

Prerequisites

  • A Kubernetes cluster with cert-manager installed
  • Node.js and npm installed on your system

Steps to Test

  1. Clone the plugins repository:

    git clone https://github.com/headlamp-k8s/plugins.git
  2. Switch to the cert-manager branch:

    git checkout cert-manager
  3. Navigate to the cert-manager plugin directory:

    cd cert-manager
  4. Install the required dependencies:

    npm install
  5. Start the plugin in development mode:

    npm run start
  6. Launch Headlamp. You should now see "Cert Manager" in the sidebar.

Optional: Generate Cert-Manager Types

To test the plugin with sample cert-manager resources:

  1. Navigate to the test-files directory:

    cd test-files
  2. Apply the sample configurations to your cluster:

    kubectl apply -f clusterIssuer.yaml
    kubectl apply -f issuer.yaml
    kubectl apply -f certificate.yaml
    kubectl apply -f order.yaml
    kubectl apply -f app.yaml

This will create:

  • A ClusterIssuer for Let's Encrypt staging
  • An Issuer for Let's Encrypt staging
  • Two Certificate resources (one using ClusterIssuer, one using Issuer)
  • An Order resource
  • Sample Nginx deployment with Ingress configurations

Demo

cert-manager.mp4

@yolossn yolossn force-pushed the cert-manager branch 2 times, most recently from edef4f5 to b8ebea9 Compare December 30, 2024 08:45
@yolossn yolossn marked this pull request as ready for review January 19, 2025 13:52
@yolossn yolossn requested a review from a team January 19, 2025 13:55
@juv
Copy link

juv commented Jan 24, 2025

This is great 👍

Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments. The plugin should also display a special error if the cert-manager is not installed.

@yolossn
Copy link
Contributor Author

yolossn commented Jan 30, 2025

image

Addressed the comments and added cert-manager not detected banner.

Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @yolossn. Apart from some suggestions, everything looks great

Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! left a couple of comments

@yolossn yolossn force-pushed the cert-manager branch 2 times, most recently from 8cff36c to c5a113e Compare February 17, 2025 07:40
@yolossn yolossn requested review from sniok and knrt10 February 17, 2025 07:40
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of notes on some possible improvements for the README.

Documenting the components/functions/fields would be useful.

@yolossn yolossn force-pushed the cert-manager branch 5 times, most recently from 1d0dee9 to e19661d Compare February 21, 2025 10:25
@joaquimrocha joaquimrocha merged commit 6add645 into main Feb 21, 2025
12 checks passed
@joaquimrocha joaquimrocha deleted the cert-manager branch February 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

6 participants