-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cert-manager plugin #143
Conversation
edef4f5
to
b8ebea9
Compare
This is great 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments. The plugin should also display a special error if the cert-manager is not installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @yolossn. Apart from some suggestions, everything looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff! left a couple of comments
8cff36c
to
c5a113e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of notes on some possible improvements for the README.
Documenting the components/functions/fields would be useful.
1d0dee9
to
e19661d
Compare
Signed-off-by: yolossn <[email protected]>
e19661d
to
46ab8ff
Compare
Testing the Cert-Manager Plugin
Prerequisites
Steps to Test
Clone the plugins repository:
Switch to the cert-manager branch:
Navigate to the cert-manager plugin directory:
cd cert-manager
Install the required dependencies:
Start the plugin in development mode:
Launch Headlamp. You should now see "Cert Manager" in the sidebar.
Optional: Generate Cert-Manager Types
To test the plugin with sample cert-manager resources:
Navigate to the test-files directory:
cd test-files
Apply the sample configurations to your cluster:
This will create:
Demo
cert-manager.mp4