Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flux: fix eslint config #174

Closed
wants to merge 0 commits into from
Closed

flux: fix eslint config #174

wants to merge 0 commits into from

Conversation

mgalesloot
Copy link
Contributor

@mgalesloot mgalesloot commented Mar 3, 2025 •
edited
Loading

Fix eslint config in Flux plugin. See #168.

In the local environment you may need to run npm install --force

ashu8912
ashu8912 reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to add the lint fixes as well right? can we do that as well in this PR?

@mgalesloot
Copy link
Contributor Author

mgalesloot commented Mar 6, 2025 •
edited
Loading

I am worried that an overall lint fix in this MR would cause merge issues for #173. The lint fix is already applied in that PR.

@mgalesloot mgalesloot closed this Mar 7, 2025
@mgalesloot mgalesloot deleted the cicd/flux-lint branch March 7, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashu8912 ashu8912 ashu8912 left review comments

@skoeva skoeva skoeva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgalesloot @ashu8912 @skoeva