Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux overview page #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Flux overview page #180

wants to merge 2 commits into from

Conversation

ashu8912
Copy link
Member

@ashu8912 ashu8912 commented Mar 6, 2025

Adds the flux overview page to the flux plugin
Screenshot 2025-03-13 at 11 36 16 AM
Screenshot 2025-03-13 at 11 39 09 AM

@ashu8912 ashu8912 force-pushed the flux-overview-page branch 2 times, most recently from c3667b8 to 556bf94 Compare March 6, 2025 06:34
@ashu8912 ashu8912 requested a review from joaquimrocha March 6, 2025 06:36
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides squashing the commits, I have found 2 things that need umproving:

  1. The names in the charts should link to their respective pages, but the link in Kustomizations is not working;
  2. The margins in the collapsible panels are too big when compared to the original design:
    Screenshot showing the big margins

Signed-off-by: ashu8912 <[email protected]>
@ashu8912 ashu8912 force-pushed the flux-overview-page branch 2 times, most recently from 62b08ea to 3490ba8 Compare March 13, 2025 06:10
@ashu8912
Copy link
Member Author

Hii @joaquimrocha updated the PR

@ashu8912 ashu8912 force-pushed the flux-overview-page branch 2 times, most recently from b9d496b to 59bcc47 Compare March 13, 2025 07:04
@joaquimrocha joaquimrocha force-pushed the flux-overview-page branch 2 times, most recently from 3310755 to b69bd57 Compare March 18, 2025 16:40
@ashu8912 ashu8912 force-pushed the flux-overview-page branch from b69bd57 to 000018e Compare March 19, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants