Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing migration to dedicated deprecator #5628

Conversation

soartec-lab
Copy link
Contributor

This is a follow-up to the PR below:

rails has deprecated the use of ActiveSupport::Deprecation in singleton in this PR, so devise has defined its own Deprecator in response to this, but there was an omission in the correction. So I fixed it.

Please note that a PR has been created that will discontinue support for EOL rails versions, and the files modified this time may also be deleted.

#5600

@soartec-lab
Copy link
Contributor Author

I think the failing tests will be fixed in #5622

@carlosantoniodasilva carlosantoniodasilva merged commit f6e73e5 into heartcombo:main Sep 13, 2023
8 of 48 checks passed
@carlosantoniodasilva
Copy link
Member

Thanks!

carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants