Clone Triennial aliyotMap since hebcal-web will mutate the results

hebcal · Sep 23, 2022 · bf97993 · bf97993
1 parent 4a0f952
commit bf97993
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hebcal/triennial",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Javascript Triennial Torah Readings",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",
@@ -58,7 +58,7 @@
     "eslint-config-google": "^0.14.0",
     "jsdoc": "^3.6.11",
     "jsdoc-to-markdown": "^7.1.1",
-    "rollup": "^2.79.0",
+    "rollup": "^2.79.1",
     "rollup-plugin-terser": "^7.0.2"
   }
 }
diff --git a/src/triennial.js b/src/triennial.js
@@ -98,6 +98,7 @@ export class Triennial {
    * @return {Object<string,Aliyah>} a map of aliyot 1-7 plus "M"
    */
   getReading(parsha, yearNum) {
+    // don't use clone() here because we want to preserve HDate objects
     const reading = shallowCopy({}, this.readings[parsha][yearNum]);
     if (reading.aliyot) {
       Object.values(reading.aliyot).map((aliyah) => calculateNumVerses(aliyah));
@@ -376,7 +377,7 @@ export function getTriennialForParshaHaShavua(ev) {
   if (typeof reading !== 'object') {
     throw new ReferenceError(`Can't load reading for ${name} in ${hyear} (year number ${yearNum})`);
   }
-  const aliyotMap = shallowCopy({}, reading.aliyot);
+  const aliyotMap = clone(reading.aliyot);
   // possibly replace 7th aliyah and/or maftir
   const reason = {};
   specialReadings(hd, false, aliyotMap, reason, parsha);