Don't parse invalid characters for attribute names

hecrj · Apr 9, 2019 · 12b783c · 12b783c
1 parent 42f759c
commit 12b783c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Html/Parser.elm b/src/Html/Parser.elm
@@ -372,7 +372,7 @@ isTagAttributeCharacter c =
 
 isSpaceCharacter : Char -> Bool
 isSpaceCharacter c =
-    c == ' ' || c == '\t' || c == '\n' || c == '\u{000D}' || c == '\u{000C}'
+    c == ' ' || c == '\t' || c == '\n' || c == '\u{000D}' || c == '\u{000C}' || c == '\u{00A0}'
 
 
 

diff --git a/tests/Main.elm b/tests/Main.elm
@@ -180,6 +180,9 @@ attributeTests =
         , test "basic13" (testParse """<html xmlns:v="urn:schemas-microsoft-com:vml"></html>""" (Element "html" [ ( "xmlns:v", "urn:schemas-microsoft-com:vml" ) ] []))
         , test "basic14" (testParse """<link rel=stylesheet
         href="">""" (Element "link" [ ( "rel", "stylesheet" ), ( "href", "" ) ] []))
+
+        -- Invalid attribute names shouldn't be parsed: https://github.com/elm/html/issues/46
+        , test "invalid character" (testParse """<p\u{00A0} ></p>""" (Element "p" [] []))
         ]