Set video "muted" attribute as property in Parser.Util.toVirtualDom #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to allow parsed
<video>
elements to play in Chrome with the bundledtoVirtualDom
utility.Chrome needs to set the
muted
attribute on<video>
elements as a property in order for autoplay to work (See this thread on Elm Discourse). Note that this is only a Chrome requirement; videos will autoplay in Firefox and Safari with the current implementation.So in short, this PR will allow the following to autoplay with
Utils.toVirtualDom
:I was careful to apply this change only to video elements. I know the code looks a bit funky; totally open if you prefer a different style of implementation.